Union and intersection types with leading operator#12386
Union and intersection types with leading operator#12386ahejlsberg merged 4 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom mariusschulz:union-and-intersection-types-with-leading-operatorCopy head branch name to clipboard
Conversation
|
Hi @mariusschulz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| } | ||
|
|
||
| function parseUnionOrIntersectionType(kind: SyntaxKind, parseConstituentType: () => TypeNode, operator: SyntaxKind): TypeNode { | ||
| parseOptional(operator); |
There was a problem hiding this comment.
You need to also add SyntaxKind.BarToken and SyntaxKind.AmpersandToken to the isStartOfType function.
There was a problem hiding this comment.
Done. Should I add another test for this?
There was a problem hiding this comment.
Might be a good idea. For example, looking at where isStartOfType is called, we wouldn't properly handle a tuple type [| 0 | 1, | "foo" | "bar"] without this change, so maybe add a test for that.
There was a problem hiding this comment.
I agree. I've updated both test files.
|
@mariusschulz Thanks! |
Fixes #12071
This pull request allows an ignored leading
|or&in a type position to give developers more formatting freedom, e.g. like this: