Fix type predicates with structurally identical types#12251
Merged
ahejlsberg merged 4 commits intoNov 15, 2016
mastermicrosoft/TypeScript:masterfrom
fixTypePredicateStructuralMatchmicrosoft/TypeScript:fixTypePredicateStructuralMatchCopy head branch name to clipboard
Merged
Fix type predicates with structurally identical types#12251ahejlsberg merged 4 commits intomastermicrosoft/TypeScript:masterfrom fixTypePredicateStructuralMatchmicrosoft/TypeScript:fixTypePredicateStructuralMatchCopy head branch name to clipboard
ahejlsberg merged 4 commits into
mastermicrosoft/TypeScript:masterfrom
fixTypePredicateStructuralMatchmicrosoft/TypeScript:fixTypePredicateStructuralMatchCopy head branch name to clipboard
Conversation
mhegazy
approved these changes
Nov 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The special casing we implemented for
instanceofin #10216 also ended up also applying to similar type predicates. This fix reverts type predicates to their original behavior.Fixes #12235.