Contextual typing of partially annotated signatures#11673
Merged
ahejlsberg merged 6 commits intoOct 18, 2016
mastermicrosoft/TypeScript:masterfrom
partiallyAnnotatedSignaturesmicrosoft/TypeScript:partiallyAnnotatedSignaturesCopy head branch name to clipboard
Merged
Contextual typing of partially annotated signatures#11673ahejlsberg merged 6 commits intomastermicrosoft/TypeScript:masterfrom partiallyAnnotatedSignaturesmicrosoft/TypeScript:partiallyAnnotatedSignaturesCopy head branch name to clipboard
ahejlsberg merged 6 commits into
mastermicrosoft/TypeScript:masterfrom
partiallyAnnotatedSignaturesmicrosoft/TypeScript:partiallyAnnotatedSignaturesCopy head branch name to clipboard
Conversation
Member
|
OK, I merged the tests from #11529. |
Regression test for #10972
Member
sandersn
approved these changes
Oct 17, 2016
sandersn
left a comment
Member
There was a problem hiding this comment.
One minor comment — there is a utility for checking the this parameter already.
| // know that all parameters (including 'this') have type annotations and nothing is | ||
| // subject to contextual typing. | ||
| const parameter = firstOrUndefined(node.parameters); | ||
| return !(parameter && parameter.name.kind === SyntaxKind.Identifier && (<Identifier>parameter.name).text === "this"); |
Member
There was a problem hiding this comment.
This can be written as !parameterIsThisKeyword(firstOrUndefined(node.parameters))
mhegazy
approved these changes
Oct 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #11529 and #11600. Thanks to @HerringtonDarkholme for the original idea regarding type inference and contextual typing of partially annotated signatures.
We probably want to move the tests over from #11529. @sandersn Maybe you want to look at that?
Fixes #4241.
Fixes #9648.
Fixes #10850.
Fixes #10972.