avoid creating syntax nodes for jsdoc comment tags#10526
Merged
zhengbli merged 1 commit intoAug 25, 2016
microsoft:mastermicrosoft/TypeScript:masterfrom
zhengbli:dontCreateSyntaxListForJsDoczhengbli/TypeScript:dontCreateSyntaxListForJsDocCopy head branch name to clipboard
Merged
avoid creating syntax nodes for jsdoc comment tags#10526zhengbli merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom zhengbli:dontCreateSyntaxListForJsDoczhengbli/TypeScript:dontCreateSyntaxListForJsDocCopy head branch name to clipboard
zhengbli merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
zhengbli:dontCreateSyntaxListForJsDoczhengbli/TypeScript:dontCreateSyntaxListForJsDocCopy head branch name to clipboard
Conversation
Member
|
What bug does this fix? |
Author
Member
|
I tried this on the new jsdoc parser and things got a lot better. 👍 🎮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoid creating syntax lists children for things in between jsdoc tags. It wasn't useful to keep them, and that way we don't need to skip them later.