allowSyntheticDefaultImports resolves to modules instead of variables#10486
Merged
sandersn merged 1 commit intoAug 22, 2016
mastermicrosoft/TypeScript:masterfrom
allowSyntheticDefaultImports-resolves-to-modulemicrosoft/TypeScript:allowSyntheticDefaultImports-resolves-to-moduleCopy head branch name to clipboard
Merged
allowSyntheticDefaultImports resolves to modules instead of variables#10486sandersn merged 1 commit intomastermicrosoft/TypeScript:masterfrom allowSyntheticDefaultImports-resolves-to-modulemicrosoft/TypeScript:allowSyntheticDefaultImports-resolves-to-moduleCopy head branch name to clipboard
sandersn merged 1 commit into
mastermicrosoft/TypeScript:masterfrom
allowSyntheticDefaultImports-resolves-to-modulemicrosoft/TypeScript:allowSyntheticDefaultImports-resolves-to-moduleCopy head branch name to clipboard
Conversation
Member
Author
Contributor
|
👍 |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10429 by improving the fix in #10096.
#10096 allowed aliasing of default imports, but did so by treating the module as a variable and resolving names on this 'variable'. This changes the check introduced in #10096 to resolve the name as a module if resolving the name on a module fails.