Unify representation of tuples and other generic types#10466
Merged
Merged
Unify representation of tuples and other generic types#10466
Conversation
Contributor
|
Will this be developed into #5453 ? Synthesized generic types and tuple types looks much like variadic kinds. |
Member
|
I quite like the changes in the error baselines. Feels neater. |
| } | ||
| else if (type.target.flags & TypeFlags.Tuple) { | ||
| writePunctuation(writer, SyntaxKind.OpenBracketToken); | ||
| writeTypeList(type.typeArguments.slice(0, getTypeReferenceArity(type)), SyntaxKind.CommaToken); |
Member
There was a problem hiding this comment.
Why copy this list? Or are there extra type arguments that slice omits? #Resolved
Member
Author
There was a problem hiding this comment.
When a generic type has a this parameter other than itself it is represented as an extra type parameter.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we unify the internal representation of tuple types and other generic types. Tuple types are now represented as regular type references to synthesized generic types of the form:
With these changes it is no longer necessary to special case tuple types throughout the type checker. All of the optimizations we have in place for regular generic type references now also apply to tuple types.
Fixes #10431. The compile time for the example drops from 1.2s to 0.08s with
--lib es5and from 30.5s to 0.11s with--lib es6.