Treat ambient shorthand declarations as explicit uses of the any type#10342
Merged
mhegazy merged 1 commit intoAug 17, 2016
mastermicrosoft/TypeScript:masterfrom
ambient_shorthand_is_explicit_anymicrosoft/TypeScript:ambient_shorthand_is_explicit_anyCopy head branch name to clipboard
Merged
Treat ambient shorthand declarations as explicit uses of the any type#10342mhegazy merged 1 commit intomastermicrosoft/TypeScript:masterfrom ambient_shorthand_is_explicit_anymicrosoft/TypeScript:ambient_shorthand_is_explicit_anyCopy head branch name to clipboard
any type#10342mhegazy merged 1 commit into
mastermicrosoft/TypeScript:masterfrom
ambient_shorthand_is_explicit_anymicrosoft/TypeScript:ambient_shorthand_is_explicit_anyCopy head branch name to clipboard
Conversation
Contributor
|
the change looks good. it now seems to be the design matter of whether we should allow this |
Member
|
👍 |
Member
|
(wait on others) |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10191.
Pending discussion with @DanielRosenwasser, @RyanCavanaugh, and @mhegazy.