Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Release 2.0] fix10289: correctly generate tsconfig.json with --lib#10310

Closed
yuit wants to merge 6 commits into
release-2.0microsoft/TypeScript:release-2.0from
release-2.0_fix10289microsoft/TypeScript:release-2.0_fix10289Copy head branch name to clipboard
Closed

[Release 2.0] fix10289: correctly generate tsconfig.json with --lib#10310
yuit wants to merge 6 commits into
release-2.0microsoft/TypeScript:release-2.0from
release-2.0_fix10289microsoft/TypeScript:release-2.0_fix10289Copy head branch name to clipboard

Conversation

@yuit

@yuit yuit commented Aug 12, 2016

Copy link
Copy Markdown
Contributor

Fix #10289

Comment thread src/compiler/commandLineParser.ts Outdated
}
}

function getKeyOfCompilerOptionValue(value: CompilerOptionsValue, customTypeMap: Map<string | number>): string | undefined {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray space after "use it"

@yuit

yuit commented Aug 15, 2016

Copy link
Copy Markdown
Contributor Author

The failure is due to the fact that "release-2.0" has dependency on TypeScript nightly which has Map/MapLike optimization

@yuit

yuit commented Aug 15, 2016

Copy link
Copy Markdown
Contributor Author

I am going to close this one and open a new one for master

@yuit yuit closed this Aug 15, 2016
@yuit yuit deleted the release-2.0_fix10289 branch August 15, 2016 22:18
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.