Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Breaking change: Depth limit now hit for some types in 4.3Β #43877

Copy link
Copy link
@dragomirtitian

Description

@dragomirtitian
Issue body actions

Bug Report

πŸ”Ž Search Terms

Depth limit 4.3

πŸ•— Version & Regression Information

  • This changed between versions 4.2 and 4.3

⏯ Playground Link

πŸ’» Code

Happens in a large codebase, I am currently unable to reproduce. The new error appears when a complex mapped & conditional type is used

πŸ™ Actual behavior

Multiple new: error TS2589: Type instantiation is excessively deep and possibly infinite.

πŸ™‚ Expected behavior

Type checks successfully as in 4.2

Note

I bisected and found that this PR is introducing this break. While the behavior outlined there seems to be a net improvement, maybe a solution that doesn't break existing types can be found? Or if not this should be outlined in the 4.3 release notes as a breaking change.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptA bug in TypeScriptFix AvailableA PR has been opened for this issueA PR has been opened for this issueRescheduledThis issue was previously scheduled to an earlier milestoneThis issue was previously scheduled to an earlier milestone

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.