Filter library redesign: tags, SidebarTabs, import/export safety, and inline editing by jschick04 · Pull Request #571 · microsoft/EventLogExpert

jschick04 · Jun 6, 2026

Summary

Redesigns the Filter Library into a 3-tab modal (Saved / Favorites / Previously Used) with tag-based organization, inline filter editing, and safer import/export. Extracts a reusable SidebarTabs<TTab> WAI-ARIA vertical tablist and removes the legacy FilterCache/FilterGroup domain behind a feature-flagged migration.

Key changes

Tags: schema + normalization, inline tag chips with hover-remove, a Tag Management panel (rename/delete across entries), and feature-flagged backslash-name to tag migration.
Modal: FilterLibraryModal 3-tab SidebarTabs<TTab> layout; per-entry overflow menu, favorites split, inline LibraryFilterRow editing (FilterEditorCore extracted, shared with FilterPane).
Import/export: versioned JSON envelope with tolerant preflight - conflict/duplicate-name/Id-collision handling, legacy SavedFilterGroup[] fallback, and malformed-input safety.
Legacy removal: deletes FilterCache/FilterGroup runtime+UI, rewires FilterPane/FilterRow to FilterLibrary, gated LegacyFilterMigrator.

Review & testing

Multi-model pre-PR review (6 reviewers) converged with zero must-fix; addressed import data-loss/crash edge cases, migration correctness, a dedup key-collision, a FilterPane scoped-CSS regression, and least-privilege tightening.
Full unit suite green (~3000 tests).

…g current keyboard contract (Up/Down/Left/Right/Home/End) and tabpanel display semantics as baseline before SidebarTabs<TTab> extraction

…abaseToolsModal with WAI-ARIA APG vertical contract (ArrowUp/Down/Home/End; ArrowLeft/Right no longer rotate), add ModalBodyLayout enum with CSS min-height fallback gated on BodyLayout=Flex, and opt DBTools/DebugLog/Settings/ReleaseNotes modals into the new layout contract

…apper and tolerant ImportPreflight with schemaVersion>1 unsupported-version handling, extract BuildFilterSetIdentityKey to FilterLibraryDedupKeys internal static with both Effects.cs call sites updated, and register via AddFilterLibraryExport method added to existing FilterLibraryServiceCollectionExtensions

…eight=80%, BodyLayout=Flex, and ImportExportClose footer wired through IFilePickerService and IFilterLibraryExportService, add LibraryEntrySection recursive sections-only hierarchy for Saved tab and per-row Rename plus per-row Export to LibraryEntryRow MoreMenu, re-key _rowRefs by (tab, id) for mount-always correctness, broaden file IO exception handling, and simplify import preflight to top-10 conflict-name list

…Library button opening FilterLibraryModal at default tab, rename AddFilter chevron menu Cached entry to Recent with matching method renames and FilterRow display-label mapping via ValueSelectItem child content, and preserve FilterMode.Cached enum for persistence compatibility

…eflight computation to prevent ArgumentException crash on duplicate-fingerprint existing entries, expose SidebarTabs.FocusActiveTabAsync and call it from FilterLibraryModal so sole-row deletions restore focus to the active tab button, and route FilterRow mode-switch announcement through GetFilterModeDisplayLabel so screen readers hear Recent instead of Cached

…ion to skip second occurrence rather than silently overwriting via UpdateEntry, and regenerate LibraryEntryId for ToAdd entries whose incoming Id collides with an existing entry's Id so store.Add does not crash with a swallowed unique-constraint violation

…ice Deserialize so legacy SavedFilterGroup[] exports from the pre-FilterLibrary FilterGroupModal no longer crash with System.NotSupportedException when LibraryEntry polymorphic deserialization rejects elements missing the Kind discriminator, by catching NotSupportedException and retrying as List<SavedFilterGroup> then converting each non-empty group to a LibraryEntryFilterSet mirroring LegacyFilterMigrator behavior, with two regression tests covering the conversion path and empty-group skipping

…TTab> extraction moved .sidebar-tabs-tabpanel rendering out of DBTools's CSS-isolation scope by wrapping the SidebarTabs invocation in a DBTools-owned div.db-tabs-container so the scope attribute reattaches at the wrapper level and rerouting every .sidebar-tabs-tabpanel ::deep selector in DatabaseToolsModal.razor.css to .db-tabs-container ::deep, restoring the two-column grid form layout, path-input-group flex behavior, elevation-warning styling, and responsive single-column collapse at 56rem

…me invocation for consistency with the other ModalBodyLayout.Flex modals DatabaseToolsModal DebugLogModal SettingsModal and ReleaseNotesModal which all omit the Title attribute, since the tablist already conveys the active section identity and the dialog title bar adds redundant chrome above the visual hierarchy

… badge, favorites-split, tags inline

…terEditor to per-row commit; clean comment-protocol violations

… ModalChrome; new --text-error token

…r dropdown contrast and inline control vertical rhythm

Copilot

Pull request overview

Redesigns the Filter Library into a tag-centric, safer-to-migrate/import/export experience, while extracting reusable modal infrastructure (vertical WAI-ARIA SidebarTabs<TTab> and a shared FilterEditorCore) and tightening accessibility/validation behaviors in modal prompts.

Changes:

Introduces SidebarTabs<TTab> (vertical tablist + roving tabindex) and rewires DatabaseTools modal to use it.
Adds tag UX (TagPicker, inline chips, TagManagementPanel) plus runtime persistence/migrations (tags column, backslash-name migration).
Extracts FilterEditorCore and extends inline modal prompt validation (validator + disabled accept + error aria wiring).

Reviewed changes

Copilot reviewed 107 out of 107 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/Unit/EventLogExpert.UI.Tests/Modal/SidebarTabsTests.cs	Unit tests for `SidebarTabs` behavior & ARIA.
tests/Unit/EventLogExpert.UI.Tests/Modal/SidebarTabsFocusContractTests.cs	Focus/tabindex contract tests for tabpanels.
tests/Unit/EventLogExpert.UI.Tests/Modal/SidebarTabsCascadeTests.cs	Cascading value propagation test through `SidebarTabs`.
tests/Unit/EventLogExpert.UI.Tests/Modal/ModalHeightInvariantTests.cs	Enforces `Height=` presence on flex-body modals.
tests/Unit/EventLogExpert.UI.Tests/Modal/ModalChromeValidateAsyncTests.cs	Inline prompt validation rendering/ARIA tests.
tests/Unit/EventLogExpert.UI.Tests/Modal/ModalBodyLayoutEnumStringificationTests.cs	Guards enum-to-string attribute literals.
tests/Unit/EventLogExpert.UI.Tests/Inputs/TagPickerTests.cs	TagPicker behavior + ARIA tests.
tests/Unit/EventLogExpert.UI.Tests/FilterPane/FilterPaneTests.cs	Updates expectations for “Recent” wording/behavior.
tests/Unit/EventLogExpert.UI.Tests/FilterLibrary/TagManagementPanelTests.cs	Tag rename/merge/delete panel tests.
tests/Unit/EventLogExpert.UI.Tests/FilterLibrary/LibrarySavedTabHeaderTests.cs	Tests “new saved filter” draft UI + validation.
tests/Unit/EventLogExpert.UI.Tests/FilterLibrary/LibraryFilterRowTests.cs	Wrapper row forwarding tests for library context.
tests/Unit/EventLogExpert.UI.Tests/FilterLibrary/LibraryEntryRowTests.cs	Library entry row tests (menu, tags, favorites).
tests/Unit/EventLogExpert.UI.Tests/FilterEditor/WrapperConformanceTests.cs	Snapshot tests for external parameter surfaces.
tests/Unit/EventLogExpert.UI.Tests/FilterEditor/FilterEditorCoreTests.cs	Tests extracted `FilterEditorCore` behavior.
tests/Unit/EventLogExpert.UI.Tests/DatabaseTools/DatabaseToolsModalTabbingTests.cs	Tabbing/roving focus tests for DB modal via tabs.
tests/Unit/EventLogExpert.UI.Tests/Alerts/PromptModalTests.cs	Prompt modal structure tests (divider).
tests/Unit/EventLogExpert.Runtime.Tests/FilterLibrary/LibraryEntryTagNormalizerTests.cs	Tag normalization + backslash migration unit tests.
tests/Unit/EventLogExpert.Runtime.Tests/FilterLibrary/LibraryEntryPolymorphicJsonTests.cs	JSON polymorphism + tags null/missing handling tests.
tests/Unit/EventLogExpert.Runtime.Tests/FilterLibrary/LegacyFilterMigratorTests.cs	Legacy migration behavior w/ backslash feature gating.
tests/Unit/EventLogExpert.Runtime.Tests/FilterLibrary/ImportPreflightCtorTests.cs	Import preflight constructor contract tests.
tests/Unit/EventLogExpert.Runtime.Tests/FilterLibrary/FilterLibraryDedupKeysTests.cs	Dedup key generation tests (incl tags).
tests/Unit/EventLogExpert.Runtime.Tests/FilterLibrary/FilterLibraryCommandsTests.cs	Command dispatch tests for tag ops.
tests/Unit/EventLogExpert.Runtime.Tests/FilterLibrary/BackslashNameMigratorTests.cs	Startup backslash migrator planning/idempotency tests.
tests/Unit/EventLogExpert.Runtime.Tests/Alerts/InlineAlertRequestTests.cs	InlineAlertRequest validation property tests.
tests/Integration/EventLogExpert.Runtime.IntegrationTests/FilterLibrary/FilterLibrarySqliteStoreTests.cs	Tags column persistence/migration integration coverage.
tests/Integration/EventLogExpert.Runtime.IntegrationTests/FilterLibrary/FilterLibraryMigrationIntegrationTests.cs	Effects wiring updated for backslash migrator dependency.
src/EventLogExpert/wwwroot/js/app.js	Adds `scrollElementIntoView` helper for inline expansion UX.
src/EventLogExpert/wwwroot/css/app.css	Global tokens/control sizing/icon alignment tweaks.
src/EventLogExpert/MauiProgram.cs	Registers export + backslash migration and ILegacyPreferences gating.
src/EventLogExpert.UI/wwwroot/Modal/SidebarTabs.js	JS preventDefault shim for vertical tab keys.
src/EventLogExpert.UI/wwwroot/DatabaseTools/DatabaseToolsModal.js	Removes DBTools-specific tab shim (migrated to SidebarTabs).
src/EventLogExpert.UI/Update/ReleaseNotesModal.razor	Switches to `BodyLayout="Flex"` for height behavior.
src/EventLogExpert.UI/Settings/SettingsModal.razor	Switches to `BodyLayout="Flex"` for height behavior.
src/EventLogExpert.UI/Modal/SidebarTabs.razor.css	Styling for new sidebar/vertical tabs layout.
src/EventLogExpert.UI/Modal/SidebarTabs.razor.cs	New reusable vertical tabs component logic/JS wiring.
src/EventLogExpert.UI/Modal/SidebarTabs.razor	New reusable vertical tabs markup/ARIA.
src/EventLogExpert.UI/Modal/ModalChrome.razor.css	Flex-body layout rules + inline validation error styling.
src/EventLogExpert.UI/Modal/ModalChrome.razor.cs	Adds `BodyLayout` and validation evaluation for prompts.
src/EventLogExpert.UI/Modal/ModalChrome.razor	Emits `data-body-layout`, prompt aria-invalid/error, disables accept.
src/EventLogExpert.UI/Modal/ModalBodyLayout.cs	New enum for chrome body layout mode.
src/EventLogExpert.UI/Inputs/Toggle.razor.css	Aligns toggle sizing to shared control height token.
src/EventLogExpert.UI/Inputs/TagPicker.razor.css	New TagPicker component styling.
src/EventLogExpert.UI/Inputs/TagPicker.razor.cs	New TagPicker component logic (normalize, dropdown, keyboard).
src/EventLogExpert.UI/Inputs/TagPicker.razor	New TagPicker markup/ARIA combobox + chips.
src/EventLogExpert.UI/FilterPane/FilterPaneAnnouncements.cs	Renames “Cached” announcement to “Recent”.
src/EventLogExpert.UI/FilterPane/FilterPane.razor.css	Adds filter set option row styling/ellipsis.
src/EventLogExpert.UI/FilterPane/FilterPane.razor.cs	“Recent” menu item + richer filter set labels + library open action.
src/EventLogExpert.UI/FilterPane/FilterPane.razor	Updates tooltips/buttons and filter set select row markup.
src/EventLogExpert.UI/FilterLibrary/TagManagementPanel.razor.css	Styling for tag management panel.
src/EventLogExpert.UI/FilterLibrary/TagManagementPanel.razor.cs	Tag rename/merge/delete behaviors + announcements/commands.
src/EventLogExpert.UI/FilterLibrary/TagManagementPanel.razor	Tag management panel UI/ARIA.
src/EventLogExpert.UI/FilterLibrary/LibrarySavedTabHeader.razor.css	Styles for “new saved filter” draft panel.
src/EventLogExpert.UI/FilterLibrary/LibrarySavedTabHeader.razor.cs	Draft state, validation, tag picker integration, command dispatch.
src/EventLogExpert.UI/FilterLibrary/LibrarySavedTabHeader.razor	Draft UI markup incl TagPicker.
src/EventLogExpert.UI/FilterLibrary/LibraryFilterRow.razor.cs	Thin wrapper over shared `FilterEditorCore` for library usage.
src/EventLogExpert.UI/FilterLibrary/LibraryFilterRow.razor	Renders `FilterEditorCore` with library callbacks.
src/EventLogExpert.UI/FilterLibrary/LibraryEntryRow.razor	Adds inline tags UI/editing + filter-set expand + menu/favorite changes.
src/EventLogExpert.UI/FilterLibrary/LibraryEntryFilterEditor.razor.css	Styles for inline filter editor within a filter set.
src/EventLogExpert.UI/FilterLibrary/LibraryEntryFilterEditor.razor.cs	Inline filter-set editor logic (add/remove/edit filters).
src/EventLogExpert.UI/FilterLibrary/LibraryEntryFilterEditor.razor	Inline filter-set editor markup.
src/EventLogExpert.UI/FilterLibrary/FilterLibraryModal.razor.css	Reworks tag filter chip bar styling.
src/EventLogExpert.UI/FilterEditor/FilterRow.razor.css	Removes legacy FilterRow-specific CSS (moved to core).
src/EventLogExpert.UI/FilterEditor/FilterRow.razor	Replaces old editor implementation with `FilterEditorCore`.
src/EventLogExpert.UI/FilterEditor/FilterEditorCore.razor.css	New shared editor core CSS.
src/EventLogExpert.UI/FilterEditor/FilterEditorCore.razor.cs	New shared editor core logic (mode switching, validation, UX).
src/EventLogExpert.UI/FilterEditor/FilterEditorCore.razor	New shared editor core markup (basic/advanced/recent modes).
src/EventLogExpert.UI/FilterEditor/Editing/FilterEditPanel.razor.css	Layout tweaks for consistent control alignment.
src/EventLogExpert.UI/FilterEditor/CachedFilterOption.cs	Shared DTO for recent/cached dropdown options.
src/EventLogExpert.UI/DebugLog/DebugLogModal.razor	Switches to `BodyLayout="Flex"`.
src/EventLogExpert.UI/DatabaseTools/DatabaseToolsModal.razor.css	Updates scoping to reach into SidebarTabs subtree.
src/EventLogExpert.UI/DatabaseTools/DatabaseToolsModal.razor.cs	Removes bespoke tab JS/logic; relies on SidebarTabs.
src/EventLogExpert.UI/DatabaseTools/DatabaseToolsModal.razor	Uses `SidebarTabs` and sets `BodyLayout="Flex"`.
src/EventLogExpert.UI/Alerts/PromptModal.razor.css	Styles divider inserted between message and input.
src/EventLogExpert.UI/Alerts/PromptModal.razor	Adds divider, minor attribute ordering change.
src/EventLogExpert.Runtime/FilterLibrary/RenameTagAction.cs	Adds action for tag rename.
src/EventLogExpert.Runtime/FilterLibrary/DeleteTagAction.cs	Adds action for tag delete.
src/EventLogExpert.Runtime/FilterLibrary/NoOpLegacyFilterMigrator.cs	Removes docblock; keeps inert implementation.
src/EventLogExpert.Runtime/FilterLibrary/NoOpBackslashNameMigrator.cs	No-op migrator for disabled feature.
src/EventLogExpert.Runtime/FilterLibrary/LibraryEntryTagNormalizer.cs	Adds tag normalization + backslash-to-tags migration + JSON converter.
src/EventLogExpert.Runtime/FilterLibrary/LibraryEntry.cs	Adds `Tags` property w/ JSON converter.
src/EventLogExpert.Runtime/FilterLibrary/LegacyMigrationFeature.cs	Adds test override + stages deletion contract updates.
src/EventLogExpert.Runtime/FilterLibrary/LegacyFilterMigrator.cs	Adds backslash gating behavior for group names.
src/EventLogExpert.Runtime/FilterLibrary/BackslashNameMigrator.cs	Adds startup migration plan for backslash-named entries.
src/EventLogExpert.Runtime/FilterLibrary/BackslashMigrationFeature.cs	Adds feature gate + test override for backslash migration.
src/EventLogExpert.Runtime/FilterLibrary/ImportPreflight.cs	Adds richer import preflight model incl blocked state.
src/EventLogExpert.Runtime/FilterLibrary/IFilterLibraryExportService.cs	Adds import/export service contract.
src/EventLogExpert.Runtime/FilterLibrary/IFilterLibraryCommands.cs	Adds `RenameTag`/`DeleteTag` commands.
src/EventLogExpert.Runtime/FilterLibrary/IBackslashNameMigrator.cs	Adds migrator interface and result record.
src/EventLogExpert.Runtime/FilterLibrary/FilterLibrarySqliteStore.cs	Adds tags column persistence + null-guards.
src/EventLogExpert.Runtime/FilterLibrary/FilterLibraryServiceCollectionExtensions.cs	Adds export + backslash migrator registrations; feature-gated legacy migrator.
src/EventLogExpert.Runtime/FilterLibrary/FilterLibraryDedupKeys.cs	Centralizes dedup key generation incl tags.
src/EventLogExpert.Runtime/FilterLibrary/FilterLibraryCommands.cs	Dispatches new tag actions.
src/EventLogExpert.Runtime/FilterLibrary/Effects.cs	Adds tag rename/delete effects + backslash startup migration wiring.
src/EventLogExpert.Runtime/EventLogExpert.Runtime.csproj	Adds InternalsVisibleTo for DynamicProxyGenAssembly2.
src/EventLogExpert.Runtime/Alerts/InlineAlertRequest.cs	Adds `Validate` function for inline prompt validation.
src/EventLogExpert.Runtime/Alerts/IAlertDialogService.cs	Adds prompt overload accepting validation callback.
src/EventLogExpert.Runtime/Alerts/AlertDialogService.cs	Pipes validation into inline prompt requests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/EventLogExpert.Runtime/Alerts/AlertDialogService.cs:79

The new DisplayPrompt(validate) overload applies validation only when an inline-alert host modal is active. In the standalone PromptModal fallback path, the validator is silently ignored, so callers can receive invalid input when no host modal is present (e.g., app startup / activation flows). Consider threading the validator through to PromptModal (e.g., pass it in the parameters dictionary and have PromptModal/ModalChrome disable OK + render an error), or otherwise enforce validation consistently across both paths.

            if (!_modalCoordinator.TryGetInlineAlertHost(out var host))
            {
                return await _openStandalonePrompt(new Dictionary<string, object?>
                {
                    ["Title"] = title,
                    ["Message"] = message,
                    ["InitialValue"] = initialValue ?? string.Empty,
                });
            }

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated 1 comment.

…polish

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated no new comments.

jschick04 added 19 commits June 4, 2026 12:06

Add pre-refactor DatabaseToolsModal tablist behavioral tests capturin…

4e48471

…g current keyboard contract (Up/Down/Left/Right/Home/End) and tabpanel display semantics as baseline before SidebarTabs<TTab> extraction

Add Tags schema to filter library

aba4372

Auto-migrate backslash names to tags + 4-step migration-aware dedup

e526bb5

Add TagPicker and LibraryEntryFilterEditor inline editor

575b3f0

Restructure LibraryEntryRow + FilterLibraryModal: drop sections, drop…

24515e4

… badge, favorites-split, tags inline

Filter library tag filters and import safety; modal styling polish

ec077b0

Extract FilterEditorCore + LibraryFilterRow; refactor LibraryEntryFil…

90e7c0a

…terEditor to per-row commit; clean comment-protocol violations

Add Validate to InlineAlertRequest; render inline validation error in…

c97a3d4

… ModalChrome; new --text-error token

Restructure library row density, tag chip overflow and rename validation

2da6bc0

Fix filter mode label, cached favorite styling, expanded inset, picke…

9efb319

…r dropdown contrast and inline control vertical rhythm

Copilot AI review requested due to automatic review settings June 6, 2026 01:10

Copilot started reviewing on behalf of jschick04 June 6, 2026 01:10 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/EventLogExpert.UI/Inputs/TagPicker.razor Outdated

Comment thread src/EventLogExpert.UI/Inputs/TagPicker.razor

jschick04 force-pushed the jschick/library-modal-redesign branch from 207d159 to e1226bf Compare June 6, 2026 01:30

jschick04 requested a review from Copilot June 6, 2026 01:31

Copilot started reviewing on behalf of jschick04 June 6, 2026 01:31 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/EventLogExpert.UI/Inputs/TagPicker.razor.cs

Comment thread src/EventLogExpert.UI/Inputs/TagPicker.razor.cs

Comment thread src/EventLogExpert.UI/FilterPane/FilterPane.razor.cs Outdated

jschick04 force-pushed the jschick/library-modal-redesign branch from e1226bf to e8c09dc Compare June 6, 2026 01:54

jschick04 requested a review from Copilot June 6, 2026 01:54

Copilot started reviewing on behalf of jschick04 June 6, 2026 01:54 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/EventLogExpert.UI/Modal/ModalChrome.razor.cs Outdated

Comment thread src/EventLogExpert.Runtime/FilterLibrary/FilterLibrarySqliteStore.cs

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/EventLogExpert.Runtime/FilterLibrary/LibraryEntryTagNormalizer.cs Outdated

Comment thread src/EventLogExpert.UI/FilterPane/FilterPane.razor Outdated

jschick04 force-pushed the jschick/library-modal-redesign branch from 28df529 to 33131fc Compare June 6, 2026 05:02

jschick04 requested a review from Copilot June 6, 2026 05:03

Copilot started reviewing on behalf of jschick04 June 6, 2026 05:03 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/EventLogExpert.UI/Modal/ModalChrome.razor.cs

jschick04 force-pushed the jschick/library-modal-redesign branch from 33131fc to 6eb8c78 Compare June 6, 2026 05:15

jschick04 requested a review from Copilot June 6, 2026 05:16

Copilot started reviewing on behalf of jschick04 June 6, 2026 05:17 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread tests/Unit/EventLogExpert.UI.Tests/Modal/ModalBodyLayoutEnumStringificationTests.cs

Comment thread tests/Unit/EventLogExpert.UI.Tests/Modal/ModalHeightInvariantTests.cs

jschick04 force-pushed the jschick/library-modal-redesign branch from 6eb8c78 to 52af226 Compare June 6, 2026 05:32

jschick04 requested a review from Copilot June 6, 2026 05:32

Copilot started reviewing on behalf of jschick04 June 6, 2026 05:33 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/EventLogExpert.UI/FilterLibrary/TagManagementPanel.razor.cs Outdated

jschick04 force-pushed the jschick/library-modal-redesign branch from 52af226 to 2b0c8b9 Compare June 6, 2026 05:46

jschick04 requested a review from Copilot June 6, 2026 05:46

Copilot started reviewing on behalf of jschick04 June 6, 2026 05:46 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/EventLogExpert.UI/FilterLibrary/LibrarySavedTabHeader.razor.cs Outdated

jschick04 force-pushed the jschick/library-modal-redesign branch from 2b0c8b9 to 2a2111b Compare June 6, 2026 16:59

jschick04 requested a review from Copilot June 6, 2026 17:00

Copilot started reviewing on behalf of jschick04 June 6, 2026 17:00 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

Comment thread src/EventLogExpert.UI/Inputs/TagPicker.razor Outdated

jschick04 force-pushed the jschick/library-modal-redesign branch from 2a2111b to e20e15b Compare June 6, 2026 17:16

Add filter library tag management with inline tag chips and edit-row …

4454471

…polish

Copilot AI review requested due to automatic review settings June 6, 2026 17:21

jschick04 force-pushed the jschick/library-modal-redesign branch from e20e15b to 4454471 Compare June 6, 2026 17:21

Copilot started reviewing on behalf of jschick04 June 6, 2026 17:21 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

jschick04 marked this pull request as ready for review June 6, 2026 17:26

jschick04 requested a review from a team as a code owner June 6, 2026 17:26

jschick04 mentioned this pull request Jun 6, 2026

Make bulk tag updates atomic, prune unloadable library rows, and reconcile modal row refs #572

Draft

Search code, repositories, users, issues, pull requests...

Conversation

jschick04 commented Jun 6, 2026

Summary

Key changes

Review & testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants