Fix performance chart ordering#8101
Open
achamayou wants to merge 1 commit into
mainmicrosoft/CCF:mainfrom
achamayou-fix-performance-plot-ordermicrosoft/CCF:achamayou-fix-performance-plot-orderCopy head branch name to clipboard
Open
Fix performance chart ordering#8101achamayou wants to merge 1 commit intomainmicrosoft/CCF:mainfrom achamayou-fix-performance-plot-ordermicrosoft/CCF:achamayou-fix-performance-plot-orderCopy head branch name to clipboard
achamayou wants to merge 1 commit into
mainmicrosoft/CCF:mainfrom
achamayou-fix-performance-plot-ordermicrosoft/CCF:achamayou-fix-performance-plot-orderCopy head branch name to clipboard
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: cedc25ac-9775-4adf-95bf-9e05e849d4ed
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the performance summary rendering so Mermaid xychart history plots preserve chronological ordering (oldest runs on the left, newest on the right), aligning visual trends with the underlying perf run timeline.
Changes:
- Remove reversal of the benchmark series when rendering Mermaid xycharts so labels/values are plotted in chronological order.
- Keep EWMA/sigma baselines consistent with the displayed time order.
Custom instructions used
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
Comment on lines
+213
to
216
| raw_values = [value for _, value in series] | ||
| values = ", ".join(f"{value:.2f}" for value in raw_values) | ||
| chronological_values = [value for _, value in series] | ||
| baseline = ewma(chronological_values) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
python -m py_compile scripts/perf_summary.pypython -m black --check scripts/perf_summary.py