Fix request exception in WEB package - #3184
#3184Merged
harsimar merged 6 commits intoMay 28, 2026
mainmicrosoft/ApplicationInsights-dotnet:mainfrom
harskaur/requestExFixmicrosoft/ApplicationInsights-dotnet:harskaur/requestExFixCopy head branch name to clipboard
Merged
Fix request exception in WEB package#3184harsimar merged 6 commits intomainmicrosoft/ApplicationInsights-dotnet:mainfrom harskaur/requestExFixmicrosoft/ApplicationInsights-dotnet:harskaur/requestExFixCopy head branch name to clipboard
harsimar merged 6 commits into
mainmicrosoft/ApplicationInsights-dotnet:mainfrom
harskaur/requestExFixmicrosoft/ApplicationInsights-dotnet:harskaur/requestExFixCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an HttpException ("Request is not available in this context") that occurred when telemetry was generated outside a request scope (e.g., TrackDependency in Application_Start). The GetRequest extension on HttpContext is hardened to catch this exception and return null, and all activity processors are updated to use the safe accessor.
Changes:
- Wrap
HttpContext.Requestaccess inHttpContextExtensions.GetRequestwith a try/catch forHttpException, returningnullinstead. - Update all activity processors (
AccountIdActivityProcessor,AuthenticatedUserIdActivityProcessor,ClientIpHeaderActivityProcessor,SessionActivityProcessor,UserActivityProcessor) to callcontext.GetRequest()and short-circuit whennull. - Update
CreateRequestNamePrivateto use the same safe accessor.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WEB/Src/Web/Web/Implementation/HttpContextExtensions.cs | Hardens GetRequest against HttpException; updates docs; refactors CreateRequestNamePrivate to use it. |
| WEB/Src/Web/Web/AccountIdActivityProcessor.cs | Uses safe GetRequest() accessor in OnEnd. |
| WEB/Src/Web/Web/AuthenticatedUserIdActivityProcessor.cs | Uses safe GetRequest() accessor in OnEnd. |
| WEB/Src/Web/Web/ClientIpHeaderActivityProcessor.cs | Uses safe GetRequest() accessor; updates request reads to local variable. |
| WEB/Src/Web/Web/SessionActivityProcessor.cs | Uses safe GetRequest() accessor in OnEnd. |
| WEB/Src/Web/Web/UserActivityProcessor.cs | Uses safe GetRequest() accessor in OnEnd. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rajkumar-rangaraj
approved these changes
May 27, 2026
This was referenced May 29, 2026
Merged
Closed
Closed
This was referenced Jun 29, 2026
This was referenced Jul 6, 2026
Open
This was referenced Jul 13, 2026
Closed
Open
This was referenced Jul 21, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the below exception:
Encountered when one calls TrackDependency inside Application_Start method.