feat(component-change-detection): add change detection strategy rule - #737
#737Merged
mgechev merged 2 commits intoFeb 5, 2019
mgechev:mastermgechev/codelyzer:masterfrom
mattlewis92:feat-component-change-detectionmattlewis92/codelyzer:feat-component-change-detectionCopy head branch name to clipboard
Merged
feat(component-change-detection): add change detection strategy rule#737mgechev merged 2 commits intomgechev:mastermgechev/codelyzer:masterfrom mattlewis92:feat-component-change-detectionmattlewis92/codelyzer:feat-component-change-detectionCopy head branch name to clipboard
mgechev merged 2 commits into
mgechev:mastermgechev/codelyzer:masterfrom
mattlewis92:feat-component-change-detectionmattlewis92/codelyzer:feat-component-change-detectionCopy head branch name to clipboard
Conversation
wKoza
requested changes
Feb 4, 2019
wKoza
left a comment
Collaborator
There was a problem hiding this comment.
Hi @mattlewis92,
Glad to see you again! I have few comments on your PR, but your code is on the good way.
mattlewis92
force-pushed
the
feat-component-change-detection
branch
from
February 5, 2019 04:20
40792ac to
86b7be0
Compare
Contributor
Author
|
@wKoza removed the option, LMK what you think! 😄 |
Collaborator
|
LGTM ! Thks! |
mgechev
approved these changes
Feb 5, 2019
Owner
|
Let's release this once we introduce support for 8.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me know if there's any changes I need to make! 😄
Closes #135