fix(rule): detect trackBy function when ngFor spans multiple lines - #813
#813Merged
wKoza merged 1 commit intoApr 22, 2019
mgechev:mastermgechev/codelyzer:masterfrom
mattlewis92:track-by-multiline-fixmattlewis92/codelyzer:track-by-multiline-fixCopy head branch name to clipboard
Merged
fix(rule): detect trackBy function when ngFor spans multiple lines#813wKoza merged 1 commit intomgechev:mastermgechev/codelyzer:masterfrom mattlewis92:track-by-multiline-fixmattlewis92/codelyzer:track-by-multiline-fixCopy head branch name to clipboard
wKoza merged 1 commit into
mgechev:mastermgechev/codelyzer:masterfrom
mattlewis92:track-by-multiline-fixmattlewis92/codelyzer:track-by-multiline-fixCopy head branch name to clipboard
Conversation
rafaelss95
self-requested a review
April 21, 2019 21:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier formats some *ngFor expressions across multiple lines which currently isn't picked up by codelyzer, I'm not sure if there is a tighter way of fixing this rather than just deleting the start of the regexp, but all the tests pass so maybe this is enough 😄