Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(rule): template-accessibility-label-for not recognizing options and interpolated values - #812

#812
Merged
mgechev merged 2 commits into
mgechev:mastermgechev/codelyzer:masterfrom
rafaelss95:fix/808Copy head branch name to clipboard
Apr 17, 2019
Merged

fix(rule): template-accessibility-label-for not recognizing options and interpolated values#812
mgechev merged 2 commits into
mgechev:mastermgechev/codelyzer:masterfrom
rafaelss95:fix/808Copy head branch name to clipboard

Conversation

@rafaelss95

Copy link
Copy Markdown
Collaborator

This:

  • Fixes the JSON schema;
  • Includes all default HTML tags that a label could be used for;
  • Includes all default label attributes that represent the for attribute;
  • Change options description to describe the options;
  • Validate options that are passed correctly;

Fixes #808 #811.

@rafaelss95
rafaelss95 requested review from mgechev and wKoza April 16, 2019 00:55
@mgechev
mgechev merged commit 1fb5d8a into mgechev:master Apr 17, 2019
@rafaelss95
rafaelss95 deleted the fix/808 branch April 19, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

template-accessibility-label-for: not recognizing id/for attributes with interpolated values

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.