feat(rule): heading element should have content - #762
#762Merged
mgechev merged 1 commit intoFeb 27, 2019
mgechev:mastermgechev/codelyzer:masterfrom
mohammedzamakhan:heading-should-have-contentCopy head branch name to clipboard
Merged
feat(rule): heading element should have content#762mgechev merged 1 commit intomgechev:mastermgechev/codelyzer:masterfrom mohammedzamakhan:heading-should-have-contentCopy head branch name to clipboard
mgechev merged 1 commit into
mgechev:mastermgechev/codelyzer:masterfrom
mohammedzamakhan:heading-should-have-contentCopy head branch name to clipboard
Conversation
mgechev
reviewed
Feb 13, 2019
Owner
|
It makes sense to merge this rule with the anchor one, same functionality? |
Owner
|
@mohammedzamakhan looks good! Would you fix the failures and we can merge! |
Contributor
Author
|
@mgechev Done |
wKoza
requested changes
Feb 16, 2019
wKoza
approved these changes
Feb 21, 2019
wKoza
left a comment
Collaborator
There was a problem hiding this comment.
thanks @mohammedzamakhan for your contributions ! just 2 little changes and LGTM !
| }); | ||
| }); | ||
|
|
||
| it('should fail with no content in anchor tag', () => { |
| <a>Anchor Content!</a> | ||
| <a><app-content></app-content></a> | ||
| <a [innerHTML]="dangerouslySetHTML"></a> | ||
| <a [innerText]="text"></a> |
Collaborator
There was a problem hiding this comment.
can you add a test with the button
Owner
|
Let's merge #754 first. |
Contributor
Author
|
@mgechev can you merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dequeuniversity.com/rules/axe/1.1/empty-heading