Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: assertFailure catch exception throw by assert (#703) - #704

#704
Merged
mgechev merged 1 commit into
mgechev:mastermgechev/codelyzer:masterfrom
someblue:mastersomeblue/codelyzer:masterCopy head branch name to clipboard
Aug 24, 2018
Merged

fix: assertFailure catch exception throw by assert (#703)#704
mgechev merged 1 commit into
mgechev:mastermgechev/codelyzer:masterfrom
someblue:mastersomeblue/codelyzer:masterCopy head branch name to clipboard

Conversation

@someblue

@someblue someblue commented Aug 24, 2018

Copy link
Copy Markdown
Contributor

Fix #703.

I think try catch statement inside assertFailure() is unnecessary. Because:

  1. If exception happens in lint(), this test case should be treated as a fail test. This exception should be catch by Chai.
  2. It's unnecessary to print exception stack. Chai will print it in a better place and format.

@mgechev
mgechev merged commit 0bac287 into mgechev:master Aug 24, 2018
@snyk-bot snyk-bot mentioned this pull request Oct 12, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgechev mgechev mgechev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@someblue @mgechev
Morty Proxy This is a proxified and sanitized view of the page, visit original site.