Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a75c204

Browse filesBrowse files
mattlewis92mgechev
authored andcommitted
fix(allow-template-call-expression): allow $any in expressions (#735)
1 parent 0ed079f commit a75c204
Copy full SHA for a75c204

2 files changed

+15-1Lines changed: 15 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/noTemplateCallExpressionRule.ts‎

Copy file name to clipboardExpand all lines: src/noTemplateCallExpressionRule.ts
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,18 @@ class TemplateVisitor extends BasicTemplateAstVisitor {
3333
}
3434

3535
class ExpressionVisitor extends RecursiveAngularExpressionVisitor {
36+
private allowedMethodNames = ['$any'];
37+
3638
visitFunctionCall(node: e.FunctionCall, context: any) {
3739
this.addFailureFromStartToEnd(node.span.start, node.span.end, Rule.FAILURE_STRING);
3840

3941
super.visitFunctionCall(node, context);
4042
}
4143

4244
visitMethodCall(node: e.MethodCall, context: any) {
43-
this.addFailureFromStartToEnd(node.span.start, node.span.end, Rule.FAILURE_STRING);
45+
if (this.allowedMethodNames.indexOf(node.name) === -1) {
46+
this.addFailureFromStartToEnd(node.span.start, node.span.end, Rule.FAILURE_STRING);
47+
}
4448

4549
super.visitMethodCall(node, context);
4650
}
Collapse file

‎test/noTemplateCallExpressionRule.spec.ts‎

Copy file name to clipboardExpand all lines: test/noTemplateCallExpressionRule.spec.ts
+10Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,16 @@ describe('no-template-call-expression', () => {
2121
`;
2222
assertSuccess('no-template-call-expression', source);
2323
});
24+
25+
it('should allow $any to wrap unknown variables', () => {
26+
let source = `
27+
@Component({
28+
template: '{{$any(info)}}'
29+
})
30+
class Bar {}
31+
`;
32+
assertSuccess('no-template-call-expression', source);
33+
});
2434
});
2535

2636
describe('failure', () => {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.