Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Latest commit

 

History

History
History
234 lines (219 loc) · 6.28 KB

File metadata and controls

234 lines (219 loc) · 6.28 KB
Copy raw file
Download raw file
Open symbols panel
Edit and raw actions
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
import { Rule } from '../src/templateClickEventsHaveKeyEventsRule';
import { assertAnnotated, assertSuccess } from './testHelper';
const {
FAILURE_STRING,
metadata: { ruleName },
} = Rule;
describe(ruleName, () => {
describe('failure', () => {
it('should fail when click is not accompanied with key events', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()"></div>
~~~~~~~~~~~~~~~~~~~~~~~~~
\`
})
class Bar {}
`;
assertAnnotated({
message: FAILURE_STRING,
ruleName,
source,
});
});
it('should fail when click is not accompanied with key events on non interactive element', () => {
const source = `
@Component({
template: \`
<header (click)="onClick()"></header>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
\`
})
class Bar {}
`;
assertAnnotated({
message: FAILURE_STRING,
ruleName,
source,
});
});
it('should fail when click is not accompanied with key events on interactive element without attributes that make them interactive', () => {
const source = `
@Component({
template: \`
<a (click)="onClick()"></a>
~~~~~~~~~~~~~~~~~~~~~~~
\`
})
class Bar {}
`;
assertAnnotated({
message: FAILURE_STRING,
ruleName,
source,
});
});
it('should fail when click is not accompanied with key events and has aria-hidden attribute as false', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" aria-hidden="false"></div>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
\`
})
class Bar {}
`;
assertAnnotated({
message: FAILURE_STRING,
ruleName,
source,
});
});
it('should fail when click is not accompanied with key events and has aria-hidden input as false', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" [attr.aria-hidden]="'false'"></div>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
\`
})
class Bar {}
`;
assertAnnotated({
message: FAILURE_STRING,
ruleName,
source,
});
});
it('should fail when click is not accompanied with key events and has role other than presentational', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" role="header"></div>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
\`
})
class Bar {}
`;
assertAnnotated({
message: FAILURE_STRING,
ruleName,
source,
});
});
it('should fail when click is not accompanied with key events and has aria-hidden attribute as false', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" role="aside"></div>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
\`
})
class Bar {}
`;
assertAnnotated({
message: FAILURE_STRING,
ruleName,
source,
});
});
it('should fail when click is not accompanied with key events and has aria-hidden input as false', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" [attr.role]="'header'"></div>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
\`
})
class Bar {}
`;
assertAnnotated({
message: FAILURE_STRING,
ruleName,
source,
});
});
});
describe('success', () => {
it('should work when click events are associated with key events', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" (keyup)="onKeyup()"></div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should work when click events are associated with key pseudo events', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" (keyup.enter)="onKeyup()"></div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should work when click events are passed to custom element', () => {
const source = `
@Component({
template: \`
<cui-button (click)="onClick()"></cui-button>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should work when element has aria-hidden', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" aria-hidden="true"></div>
<div (click)="onClick()" [attr.aria-hidden]="true"></div>
<div (click)="onClick()" [attr.aria-hidden]="ariaHidden"></div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should work when element has presentation role', () => {
const source = `
@Component({
template: \`
<div (click)="onClick()" role="presentation"></div>
<div (click)="onClick()" [attr.role]="'none'"></div>
<div (click)="onClick()" [attr.role]="roleName"></div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should work when element is interactive', () => {
const source = `
@Component({
template: \`
<input (click)="onClick()">
<button (click)="onClick()"></button>
<textarea (click)="onClick()"></textarea>
<select (click)="onClick()">
<option (click)="onClick()"></option>
</select>
<textarea (click)="onClick()"></textarea>
<a href="#" (click)="onClick()"></a>
<a [attr.href]="href" class="anchor" (click)="onClick()"></a>
<a [routerLink]="'route'" (click)="onClick()"></a>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
});
});
Morty Proxy This is a proxified and sanitized view of the page, visit original site.