Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Adding a new Module for unsupported layer. Adding test for unsupported layers. Simple logging for unsupported layers#1505

Closed
styusuf wants to merge 1 commit into
meta-pytorch:mastermeta-pytorch/captum:masterfrom
styusuf:export-D69792994styusuf/captum:export-D69792994Copy head branch name to clipboard
Closed

Adding a new Module for unsupported layer. Adding test for unsupported layers. Simple logging for unsupported layers#1505
styusuf wants to merge 1 commit into
meta-pytorch:mastermeta-pytorch/captum:masterfrom
styusuf:export-D69792994styusuf/captum:export-D69792994Copy head branch name to clipboard

Conversation

@styusuf

@styusuf styusuf commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

Differential Revision: D69792994

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

styusuf added a commit to styusuf/captum that referenced this pull request Feb 21, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

1 similar comment
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

styusuf added a commit to styusuf/captum that referenced this pull request Feb 21, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

styusuf added a commit to styusuf/captum that referenced this pull request Feb 21, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

@styusuf
styusuf force-pushed the export-D69792994 branch from f5b2c17 to 35912f9 Compare March 2, 2025 02:46
styusuf added a commit to styusuf/captum that referenced this pull request Mar 2, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

styusuf added a commit to styusuf/captum that referenced this pull request Mar 3, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@styusuf
styusuf force-pushed the export-D69792994 branch from 35912f9 to dc400ac Compare March 3, 2025 17:40
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

styusuf added a commit to styusuf/captum that referenced this pull request Mar 3, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@styusuf
styusuf force-pushed the export-D69792994 branch from dc400ac to 538d753 Compare March 3, 2025 18:00
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

styusuf added a commit to styusuf/captum that referenced this pull request Mar 3, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@styusuf
styusuf force-pushed the export-D69792994 branch from 538d753 to 976bf30 Compare March 3, 2025 19:27
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

styusuf added a commit to styusuf/captum that referenced this pull request Mar 4, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@styusuf
styusuf force-pushed the export-D69792994 branch from 976bf30 to 11ccffa Compare March 4, 2025 21:38
styusuf added a commit to styusuf/captum that referenced this pull request Mar 4, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@styusuf
styusuf force-pushed the export-D69792994 branch from 11ccffa to 38ecc4c Compare March 4, 2025 21:39
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

@styusuf
styusuf force-pushed the export-D69792994 branch from 38ecc4c to 2fa1018 Compare March 4, 2025 21:43
styusuf added a commit to styusuf/captum that referenced this pull request Mar 4, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:
Pull Request resolved: meta-pytorch#1505

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

styusuf added a commit to styusuf/captum that referenced this pull request Mar 4, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:
Pull Request resolved: meta-pytorch#1505

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
@styusuf
styusuf force-pushed the export-D69792994 branch from 2fa1018 to f56045a Compare March 4, 2025 21:55
styusuf added a commit to styusuf/captum that referenced this pull request Mar 5, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Differential Revision: D69792994
styusuf added a commit to styusuf/captum that referenced this pull request Mar 5, 2025
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Reviewed By: craymichael

Differential Revision: D69792994
@styusuf
styusuf force-pushed the export-D69792994 branch from f56045a to 3fed752 Compare March 5, 2025 21:44
…d layers. Simple logging for unsupported layers (meta-pytorch#1505)

Summary:
Pull Request resolved: meta-pytorch#1505

We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.

A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class.

Reviewed By: craymichael

Differential Revision: D69792994
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69792994

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in c9688bb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.