Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix #5572: Allow passing empty range to broken_barh #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 28, 2015
Merged

Fix #5572: Allow passing empty range to broken_barh #5600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f255c33
Fix #5572: Allow passing empty range to broken_barh
mdboom Dec 1, 2015
76d681b
Use iterator rather than index
mdboom Dec 2, 2015
115fca7
Fix typo
mdboom Dec 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions 12 lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2339,8 +2339,16 @@ def broken_barh(self, xranges, yrange, **kwargs):
.. plot:: mpl_examples/pylab_examples/broken_barh.py
"""
# process the unit information
self._process_unit_info(xdata=xranges[0],
ydata=yrange[0],
if len(xranges):
xdata = six.next(iter(xranges))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just use next here https://docs.python.org/2/library/functions.html#next I think six provides it to support back to 2.4 or something like that.

else:
xdata = None
if len(yrange):
ydata = six.next(iter(yrange))
else:
ydata = None
self._process_unit_info(xdata=xdata,
ydata=ydata,
kwargs=kwargs)
xranges = self.convert_xunits(xranges)
yrange = self.convert_yunits(yrange)
Expand Down
6 changes: 6 additions & 0 deletions 6 lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4241,6 +4241,12 @@ def _helper_y(ax):
assert assert_array_equal(ax_lst[0][1].get_xlim(), orig_xlim)


@cleanup
def test_broken_barh_empty():
fig, ax = plt.subplots()
ax.broken_barh([], (.1, .5))


if __name__ == '__main__':
import nose
import sys
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.