Fix #5572: Allow passing empty range to broken_barh #5600
Conversation
| self._process_unit_info(xdata=xranges[0], | ||
| ydata=yrange[0], | ||
| if len(xranges): | ||
| xdata = xranges[0] |
There was a problem hiding this comment.
Probably safer to do xdata = next(iter(xrange)) in a try...except block. pandas Series slice on index rather than position
try:
xdata = next(iter(xranges))
except (StopIteration, TypeError):
xdata = None|
I dimly recall seeing this sort of pre-processing prior to _process_unit_info elsewhere; does it need to be factored out? E.g., could it be added to _process_unit_info itself, perhaps activated with a kwarg? Is there also a Pandas conversion stage that we are stuck having to use now, so that we don't end up sprinkling things like six.next(iter(xxx)) all over the place? |
|
This is now ready to merge. |
| self._process_unit_info(xdata=xranges[0], | ||
| ydata=yrange[0], | ||
| if len(xranges): | ||
| xdata = six.next(iter(xranges)) |
There was a problem hiding this comment.
I think we can just use next here https://docs.python.org/2/library/functions.html#next I think six provides it to support back to 2.4 or something like that.
Fix #5572: Allow passing empty range to broken_barh
Fix #5572: Allow passing empty range to broken_barh
|
backported as 8228dbd |
No description provided.