Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Pass AbstractMovieWriter.setup kwargs through Animation.save #28822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 14, 2024

PR summary

This is a rebase of #11863 with the addition of a test. That PR was closed because #16082 defaulted animations to save intermediate files to a temporary directory. However, that didn't actually fix the ability to pass arguments to setup, which means the idea from #16082 to "just pass frame_prefix if you want to save the temporary files" was never possible.

PR checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.