Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Default to writing animation frames to a temporary directory. #16082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

Default to writing animation frames to a temporary directory. #16082

merged 1 commit into from
Jan 4, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 3, 2020

(We could later deprecate clean_temp, as the user can simply pass a
non-None frame_prefix to write temporary frames whereever they want and
keep them there.)

Redo of #3536 (see motivation there) and some of #11860, also solves #11863 (comment).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Defaut to writing animation frames to a temporary directory.
cc3482f 
(We could later deprecate clean_temp, as the user can simply pass a
non-None frame_prefix to write temporary frames whereever they want and
keep them there.)
timhoffm
timhoffm reviewed Jan 4, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not looked much into this, but it looks confusing that frame_prefix determines cleanup but clear_temp as well. Is this really necessary?

@anntzer
Copy link
Contributor Author

anntzer commented Jan 4, 2020

I plan to deprecate clear_temp later. (One can't really support frame_prefix=None (i.e. tmpdir) + clear_temp=False without adding a completely separate code path for creating a tmpdir with mkdtemp so that it doesn't get deleted, but that seems just not worth it.)

@timhoffm timhoffm merged commit bc04c8a into matplotlib:master Jan 4, 2020
@anntzer anntzer mentioned this pull request Jan 4, 2020
Merged
6 tasks
@QuLogic QuLogic added this to the v3.3.0 milestone Mar 24, 2020
@anntzer anntzer deleted the animation-tmpdir branch November 29, 2020 14:39
@jklymak jklymak mentioned this pull request Apr 15, 2021
Closed
@QuLogic QuLogic changed the title Defaut to writing animation frames to a temporary directory. Default to writing animation frames to a temporary directory. Aug 30, 2024
@QuLogic QuLogic mentioned this pull request Sep 14, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: animation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @timhoffm @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.