FIX: Made AffineDeltaTransform pass-through properly #28375
Conversation
fad4ead to
58379e3
Compare
|
@anntzer Could you take a look at this please? |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Before this change, transform sub-graphs with ``AffineDeltaTransform`` did not update correctly. | ||
| This PR ensures that changes to axis limits are passed through correctly to the underlying transform. |
There was a problem hiding this comment.
Wording is not really optimal (considering that this will be part of a changelog). Also the reference to axes limits may be a bit too specific (AffineDeltaTransform does not refer to transData/transLimits in itself).
Also this isn't really an API change, but rather a bugfix (so it may belong more to the whatsnew folder?)
There was a problem hiding this comment.
My lens on this was a bit hyper-specific. I am happy to go with any suggestion you may have on this.
There was a problem hiding this comment.
At the very least, it's "when the child transform changes", not specifically axis limits (as that's only the case for the example in #28364.)
There was a problem hiding this comment.
@QuLogic Thanks for the suggestion. Done.
58379e3 to
0b91d8e
Compare
PR summary
Makes
mtrans.AffineDeltaTransformupdate correctly when axis bounds change. Change made by @anntzercloses #28372
enables the proposed example in #28364 to work correctly
Testing
A combination of manual and unit tests.
Manually verified that the example above works as expected now:
Before:
After:
Unit test shows that the parent transform is invalidated when the child is now.
PR checklist