Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ENH: Added an example of combined transforms and more #28364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from

Conversation

joe-saronic
Copy link

@joe-saronic joe-saronic commented Jun 10, 2024

PR summary

This PR adds a showcase for a couple of new things I've learned, especially regarding transformations.

The example shows how to make circles whose size is fixed in data space relative to one axis while still remaining circles. It uses dates on the x-axis to ensure that the scales of the x- and y-axes are wildly different.

This PR is based on the research I did for https://stackoverflow.com/q/78598087/2988730. It will not work properly with interactive zoom until #28375 is merged.

PR checklist

@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Jun 10, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@QuLogic
Copy link
Member

QuLogic commented Jun 28, 2024

Why are the commits here attributed to someone else?

@joe-saronic
Copy link
Author

joe-saronic commented Jun 29, 2024

@QuLogic Because I made a mess of using my personal and work github accounts. Both are actually me. Specifically, I used my work account to make the PR, but the repo is configured with my personal email. The names should match though.

@joe-saronic
Copy link
Author

@QuLogic If you are interested, this PR also requires #28375 to work completely, which needs review.

@joe-saronic
Copy link
Author

Bump

@joe-saronic
Copy link
Author

@QuLogic How does this look?

@story645
Copy link
Member

Given the amount of explanation here, I wonder if this may work better as a subsection of https://matplotlib.org/devdocs/users/explain/artists/transforms_tutorial.html

@joe-saronic
Copy link
Author

I can see that being an option too. Will look into it when I have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: examples files in galleries/examples
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.