Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Reset _transformSet in Artist.remove #25205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

Reset _transformSet in Artist.remove #25205

wants to merge 1 commit into from

Conversation

komoto48g
Copy link

@komoto48g komoto48g commented Feb 12, 2023 •
edited
Loading

PR Summary

This PR fixes #25168

PR Checklist

Documentation and Tests

  • [N/A] Has pytest style unit tests (and pytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

github-actions[bot]
github-actions bot reviewed Feb 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell
Copy link
Member

I am more in favor of preventing re-adding artists (see #24626) because I suspect that this is one of a bunch of connections that are not being properly cleaned up.

@melissawm
Copy link
Member

I am guessing from @tacaswell's comment that tests are not all that is needed here, but may be a good starting point. @komoto48g if you need help with adding the tests, let us know. Here are the Matplotlib testing guidelines: https://matplotlib.org/devdocs/devel/testing.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Immediateduck Immediateduck Immediateduck approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status: needs rebase status: needs tests
Projects
First Time Contributors
Status: Waiting for author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH]: Remove artists from axes completely.
4 participants
@komoto48g @tacaswell @melissawm @Immediateduck
Morty Proxy This is a proxified and sanitized view of the page, visit original site.