Mnt/no reset axes #24626
Draft
Mnt/no reset axes #24626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df7fe30 to
5d60904
Compare
|
On consideration, this has sat for so long it can sit a bit longer. We have more than enough to try and get in for 3.7 so defer this to 3.8. |
This was referenced Feb 13, 2023
|
Does this mean ArtistList does not work anymore? It seems like starting from 3.7.0, pop() function doesn't work on it... |
|
That has nothing to do with this PR; see https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.7.0.html#modification-of-axes-children-sublists |
|
Ah ok, thank you. |
5d60904 to
4f8ec8e
Compare
This is exactly the sort of error that this check is supposed to catch.
4f8ec8e to
0c80e8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This makes our Artists very picky about being re-added to Axes / Figures once they have been removed. Currently there is enough checking in place that it should not be possible to try and add the Artist to more than one simultaneously, but it is not clear we actually do enough clean up to make these re-added Aritsts actually work. I suspect in most cases where users are removing / readding Aritsts they would be better off using
set_visible(), but I have no idea how common it actually is.Open questions:
ArtistListdeprecation to expire (if we are ever going to expire those)?I think this is sufficiently tested, but needs API change notes, but waiting for the above decisions before writing them.
In any case, the change to the OffsetBox test should probably be pulled out and if we do not take this, find a way to make that error out for maybe other reasons.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/