Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update thirdparty scalebar#15561

Merged
jklymak merged 1 commit intomatplotlib:mastermatplotlib/matplotlib:masterfrom
timhoffm:scalebartimhoffm/matplotlib:scalebarCopy head branch name to clipboard
Oct 29, 2019
Merged

Update thirdparty scalebar#15561
jklymak merged 1 commit intomatplotlib:mastermatplotlib/matplotlib:masterfrom
timhoffm:scalebartimhoffm/matplotlib:scalebarCopy head branch name to clipboard

Conversation

@timhoffm
Copy link
Member

@timhoffm timhoffm commented Oct 28, 2019

PR Summary

This is a follow-up to #15537.

  • Used jpg as image format and ran it through an online jpg compressor: Filesize 33kb -> 18kb (lossless).
  • remove forcing an image size, and instead let it be rendered in original size.
    Note: I think this size is sufficient, but we can also make a larger one if needed.

@timhoffm
Copy link
Member Author

timhoffm commented Oct 29, 2019

This is the result:
https://26188-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/thirdpartypackages/index.html#matplotlib-scalebar

@jklymak jklymak merged commit 602db5a into matplotlib:master Oct 29, 2019
@timhoffm
Copy link
Member Author

timhoffm commented Oct 29, 2019

@meeseeksdev backport to v3.2.x

@timhoffm timhoffm added this to the v3.2.0 milestone Oct 29, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 29, 2019
@jklymak
Backport PR matplotlib#15561: Update thirdparty scalebar
fd88e95
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 29, 2019
Merged
@timhoffm timhoffm deleted the scalebar branch October 29, 2019 20:27
timhoffm added a commit that referenced this pull request Oct 29, 2019
@timhoffm
Merge pull request #15570 from meeseeksmachine/auto-backport-of-pr-15…
4439d9d 
…561-on-v3.2.x

Backport PR #15561 on branch v3.2.x (Update thirdparty scalebar)
@ppinard ppinard mentioned this pull request Nov 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@timhoffm @jklymak
Morty Proxy This is a proxified and sanitized view of the page, visit original site.