Add a third party package in the doc: matplotlib-scalebar#15537
Add a third party package in the doc: matplotlib-scalebar#15537tacaswell merged 2 commits intomatplotlib:mastermatplotlib/matplotlib:masterfrom ppinard:masterCopy head branch name to clipboard
Conversation
|
PR in response to ppinard/matplotlib-scalebar#21 |
timhoffm
left a comment
There was a problem hiding this comment.
Thanks! Could you please try to reduce the png file size. We've got a number of images on that page and we try to be nice to users with limited bandwidth.
Might scale down a bit, but more importantly, there are a number of online png compressors. Running the image through one of these should significantly reduce the size (you may also try different ones if you are interested, as not all compressors are equally good).
|
@timhoffm I was able to reduce the size by ~5. I decreased the resolution by 2 and using Gimp I converted the image to greyscale and applied the highest compression. |
|
The original image is from Wikipedia Commons and it is in in the Public Domain: https://commons.wikimedia.org/wiki/File:Gold_on_Carbon.jpg |
…atplotlib-scalebar
|
Thanks @ppinard ! |
|
@tacaswell I'm afraid the merge was a bit too fast.
Given that this is already merged, how do we proceed from here? Is there any way of replacing that image without carrying the unused version in the repo for eternity and without breaking existing clones? Edit: On a side-note, the above issues are present for a number of images on https://matplotlib.org/devdocs/thirdpartypackages/index.html. Changing them would be a separate matter of discussion. |
|
Push a new PR to fix those things and once that is merged add it to the backport PR. |
|
I will make a new PR today. |
…537-on-v3.2.x Backport PR #15537 on branch v3.2.x (Add a third party package in the doc: matplotlib-scalebar)
PR Summary
PR Checklist