Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Backport PR #13412 and #13337 on branch v3.0.x #13418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2019
Merged

Backport PR #13412 and #13337 on branch v3.0.x #13418

merged 2 commits into from
Feb 12, 2019

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 12, 2019 •
edited
Loading

PR Summary

  • CI: add additional qt5 deb package on travis
  • Bump to flake8 3.7.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.0.3 milestone Feb 12, 2019
@QuLogic QuLogic mentioned this pull request Feb 12, 2019
Merged
6 tasks
@anntzer @QuLogic
Bump to flake8 3.7.
4434dc0 
The associated bump to pycodestyle 2.5 caught a few more style nits.
@QuLogic
Copy link
Member Author

QuLogic commented Feb 12, 2019

I had to throw in one extra change to lib/matplotlib/backends/qt_editor/figureoptions.py if anyone wants to verify that.

@QuLogic QuLogic changed the title Backport PR #13412 on branch v3.0.x Backport PR #13412 and #13337 on branch v3.0.x Feb 12, 2019
@QuLogic
Copy link
Member Author

QuLogic commented Feb 12, 2019

Merging to fix builds.

@QuLogic QuLogic merged commit 69c2a9d into matplotlib:v3.0.x Feb 12, 2019
@QuLogic QuLogic deleted the backport-13412 branch February 12, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @anntzer
Morty Proxy This is a proxified and sanitized view of the page, visit original site.