Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Bump to flake8 3.7. #13337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Bump to flake8 3.7. #13337

merged 1 commit into from
Feb 1, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 31, 2019

flake8 3.7 seems to be working fine now.

The associated bump to pycodestyle 2.5 caught a few more style nits.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The associated bump to pycodestyle 2.5 caught a few more style nits.
@dopplershift
Copy link
Contributor

Is there any reason that this change should be affecting what tests we're running? Codecov.io is showing a lot of changes, and it doesn't look spurious.

@tacaswell
Copy link
Member

It looks like appveyor did not fire, maybe this is the coverage we get only from appveyor?

lib/matplotlib/pyplot.py Show resolved Hide resolved
@tacaswell tacaswell added this to the v3.1 milestone Feb 1, 2019
@timhoffm
Copy link
Member

timhoffm commented Feb 1, 2019

Might be that we need to take care of flake8 also in the other branches (e.g. it's failing in this backport #13340).

@tacaswell tacaswell merged commit 68e8d95 into matplotlib:master Feb 1, 2019
@anntzer anntzer deleted the flake837 branch February 1, 2019 14:38
@tacaswell
Copy link
Member

@meeseeksbot backport to v3.0.x

@QuLogic
Copy link
Member

QuLogic commented Feb 12, 2019

@meeseeksdev backport to v3.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Feb 12, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 68e8d9543abce31da04a79970fdfb5dea914a540
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #13337: Bump to flake8 3.7.'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-13337-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR #13337 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@QuLogic
Copy link
Member

QuLogic commented Feb 12, 2019

OK, I'll put it in #13418.

@tacaswell
Copy link
Member

Thanks @QuLogic !

@QuLogic QuLogic modified the milestones: v3.1.0, v3.0.3 Feb 12, 2019
QuLogic added a commit that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.