Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Run setupext qt checks in a subprocess rather than with multiprocessing. #10886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Run setupext qt checks in a subprocess rather than with multiprocessing. #10886

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 27, 2018

PR Summary

(yes, having code as strings is a bit ugly, but less that having multiprocessing in setup.py...)

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Build label Mar 27, 2018
@tacaswell tacaswell added this to the v3.0 milestone Mar 27, 2018
@tacaswell
Copy link
Member

Can you also remove the multiprocess import now?

Bit surprised that you can import both pyqt and pyside in one process.

@anntzer
Copy link
Contributor Author

anntzer commented Mar 27, 2018

#10885 needs to be merged too before removing multiprocessing (or I can rebase the later of the two PRs).
I think the impossibility of importing qt4 and qt5 in the same process is due to C symbol clash(?), so that's not a problem with pyqt and pyside(?).

@anntzer anntzer modified the milestones: v3.0, unassigned Jul 16, 2018
@anntzer
Copy link
Contributor Author

anntzer commented Jul 16, 2018

This will basically become obsolete once #11600 or a variant thereof gets merged (we won't be checking for the GUI toolkits during the build at all anymore).
I guess #11600 (or variant) should get in soon so I'll remilestone this away from 3.0 for now; I'll close this once #11600 goes in (it's not a problem either if this gets merged if #11600 ends up taking too long).

@anntzer
Copy link
Contributor Author

anntzer commented Aug 31, 2018

Obsoleted by #11962.

@anntzer anntzer closed this Aug 31, 2018
@anntzer anntzer deleted the setupext-qt branch August 31, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @tacaswell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.