Move GTK3 setupext checks to within the process. #10885
Merged
+24
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lazka
reviewed
Mar 28, 2018
| return msg | ||
| else: | ||
| raise CheckFailed(msg) | ||
| return "version {}.{}.{}".format( |
Now that we don't support GTK2, there is no need to run the checks in a separate process anymore (gtk3, pyqt5, tk, and wx can all be imported into the same process). A cairo binding is also a dependency for gtk3agg, so the checks for gtk3agg and gtk3cairo should be literally identical.
QuLogic
approved these changes
Jun 24, 2018
|
Thanks @anntzer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we don't support GTK2, there is no need to run the checks in a
separate process anymore (gtk3, pyqt5, tk, and wx can all be imported
into the same process).
A cairo binding is also a dependency for gtk3agg, so the checks for
gtk3agg and gtk3cairo should be literally identical.
PR Summary
PR Checklist