Fix to allow both old and new style wx versions #10363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing |
|
I hope so, easy to fix a mistype. Not really sure how the docs are built here |
dstansby
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Apologies, I made a mistake in my previous PR #10362 and it got merged in just as I realised.
StrictVersion will fail with a value error on the old style versions like '2.8.12.0'.
This can be resolved by attempting to call StrictVersion and on failure, use a LooseVersion.
Both can be compared correctly with str("x.x.x") and the conditionals do not overlap.
I have now tested this functionality locally but am not entirely sure how I would go about writing a test to cover it in the library
PR Checklist