Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Switch to using StrictVersion in wx_compat.py #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2018
Merged

Switch to using StrictVersion in wx_compat.py #10362

merged 1 commit into from
Feb 1, 2018

Conversation

BrennanGit
Copy link
Contributor

PR Summary

Under LooseVersion, the new version of wxPython (4.0.0) is judged to come before the previous beta release (4.0.0b2) which breaks the AddTool function in the same way that #9187 was designed to address.

As far as I can tell, wxPython now adheres to the StrictVersion principles so it seems like a good fix here.

For the moment, this is blocking our upgrade to Phoenix 4.0.0 so hopefully this can make it in to the next release.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 1, 2018
@jklymak jklymak added this to the v2.2 milestone Feb 1, 2018
@jklymak jklymak added the GUI: wx label Feb 1, 2018
@tacaswell tacaswell merged commit 782f35d into matplotlib:master Feb 1, 2018
@BrennanGit BrennanGit mentioned this pull request Feb 1, 2018
Merged
6 tasks
@mesalu mesalu mentioned this pull request Feb 1, 2018
Closed
@jenshnielsen jenshnielsen mentioned this pull request Feb 8, 2018
Closed
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI: wx Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BrennanGit @tacaswell @QuLogic @jklymak
Morty Proxy This is a proxified and sanitized view of the page, visit original site.