Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add option to pass a URL explicitly instead of reading from settings#88

Merged
markfinger merged 1 commit into
markfinger:mastermarkfinger/python-react:masterfrom
jchen-eb:urljchen-eb/python-react:urlCopy head branch name to clipboard
Oct 8, 2018
Merged

Add option to pass a URL explicitly instead of reading from settings#88
markfinger merged 1 commit into
markfinger:mastermarkfinger/python-react:masterfrom
jchen-eb:urljchen-eb/python-react:urlCopy head branch name to clipboard

Conversation

@jchen-eb

Copy link
Copy Markdown
Contributor

I have a use case where I need to support both the original behavior of reading the url from settings, and the ability to pass a different url conditionally.

@markfinger

Copy link
Copy Markdown
Owner

Thanks for the PR.

My dev machine is currently having net woes, but I should be able to merge the PR and publish a new release next week.

@markfinger markfinger merged commit 2e23f77 into markfinger:master Oct 8, 2018
@markfinger

Copy link
Copy Markdown
Owner

Thanks again for the PR, @jchen-eb. I've merged your changes in and published a 4.3.0 release to PyPI.

Sorry for the delay, I've been moving house 😫

@jchen-eb

Copy link
Copy Markdown
Contributor Author

Thanks for merging and publishing the new version @markfinger ! Looking forward to using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.