fix self check in equals of Type#3995
Merged
filiphr merged 1 commit intoFeb 14, 2026
mapstruct:mainmapstruct/mapstruct:mainfrom
hduelme:fix-self-check-in-equals-of-Typehduelme/mapstruct:fix-self-check-in-equals-of-TypeCopy head branch name to clipboard
Merged
fix self check in equals of Type#3995filiphr merged 1 commit intomapstruct:mainmapstruct/mapstruct:mainfrom hduelme:fix-self-check-in-equals-of-Typehduelme/mapstruct:fix-self-check-in-equals-of-TypeCopy head branch name to clipboard
filiphr merged 1 commit into
mapstruct:mainmapstruct/mapstruct:mainfrom
hduelme:fix-self-check-in-equals-of-Typehduelme/mapstruct:fix-self-check-in-equals-of-TypeCopy head branch name to clipboard
Conversation
Member
|
Thanks @hduelme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #3994, I noticed that in
Type.equals,hasExtendsBound()andhasSuperBound()are compared to themselves, which always evaluates totrue.As far as I can tell, equals is currently only used for
Mapcomparisons. Nevertheless, this behavior seems wrong.