Fixed warnings and notices issued by PHP 8.1.4#2
Merged
rijnb merged 2 commits intoSep 28, 2022
Merged
Fixed warnings and notices issued by PHP 8.1.4#2
Conversation
Author
|
done
Bert Hooyman
From: Rijn Buve ***@***.***>
Sent: Wednesday, September 28, 2022 17:14
To: mapcode-foundation/mapcode-php ***@***.***>
Cc: BertHooyman ***@***.***>; Author ***@***.***>
Subject: Re: [mapcode-foundation/mapcode-php] Fixed warnings and notices issued by PHP 8.1.4 (PR #2)
Great. Thanks! Can you please also
* update the version number in the mapcode_api.php file
* update the .doc file to state the supported PHP version
—
Reply to this email directly, view it on GitHub <#2 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC6RSLBIA5X476JYWM4IPPTWAROBZANCNFSM6AAAAAAQXZ4MXQ> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/AC6RSLH6VNW2BZLNHCPTIOLWAROBZA5CNFSM6AAAAAAQXZ4MXSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSLFJFMG.gif> Message ID: ***@***.*** ***@***.***> >
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several api functions (decodeTriple and decode) returned either an object or an int 0. This leads to warnings in the calling code under PHP 8.1. As a fix, these functions now return null rather than 0.
In various places, associative arrays were accessed using non-existing keys. E.g. $GLOBALS['redivar'], $_REQUEST['s'], $_GET['edge'] and $_GET['start']. Code has been extended to avoid such access.
In the function territory_code_tests() in unittest.php, there was a $testdata array entry for 'US-CA OTHER TEXT' having a context of '-1 -1'. This is evaluated as -2 and that leads to a warning in PHP 8.1. The context has been fixed to '-1'
Indexing into an uninitialized array leads to warning in PHP 8.1. This has been fixed for accessing $result[$p] in to_ascii()