Registry Settings: enhancements and new settings implementation #2643
Merged
Kvarkas merged 7 commits intoOct 1, 2024
mRemoteNG:v1.77.3-devmRemoteNG/mRemoteNG:v1.77.3-devfrom
xRushG:asyncRegSettingCopy head branch name to clipboard
Merged
Registry Settings: enhancements and new settings implementation
#2643Kvarkas merged 7 commits intomRemoteNG:v1.77.3-devmRemoteNG/mRemoteNG:v1.77.3-devfrom xRushG:asyncRegSettingCopy head branch name to clipboard
Kvarkas merged 7 commits into
mRemoteNG:v1.77.3-devmRemoteNG/mRemoteNG:v1.77.3-devfrom
xRushG:asyncRegSettingCopy head branch name to clipboard
Conversation
…settings loading - Added the RegistryLoader class to handle loading of registry settings. - Implemented Lazy<T> for singleton pattern to ensure only one instance of RegistryLoader is created. - Added support for asynchronous loading of registry settings to improve performance in async workflows. - Designed the class with thread safety in mind, leveraging ConcurrentDictionary for storage. - Included logging of debug messages to track the load process and timing.
…settings, remove obsolete code - Moved async registry loading logic to OptRegistryCredentialsPage and OptRegistryUpdatesPage to improve structure and maintainability. - Removed obsolete logic and redundant code that is no longer needed due to the new asynchronous architecture. - Enhanced settings management to take advantage of the just-in-time loading mechanism. - Improved performance by ensuring registry settings are loaded asynchronously right before they are needed by the UI or application logic, minimizing unnecessary loads. - Update documents
…nd Startup and Exit Page with async logic - Added registry settings for the Notification Page. - Added registry settings for the Appearance Page. - Added registry settings for the Startup and Exit Page. - All settings implemented with async registry logic
… settings related to startup and exit.
- Added registry settings for the Tabs and Panel Page. - All settings implemented with async registry logic - Comment unused settings - Update documents
- Added registry settings for the Connection Page. - Added registry settings for the SQL Serverl Page. - All settings implemented with async registry logic - Comment unused settings for Connection Page - Update documents
…rator - Added new registry settings for managing security-related configurations on the Security Page. - Implemented an encryption key generator to securely generate a password for store in the registry. - Passwords are placed encrypted on the clipboard for 30 seconds. - Update documents and finalize comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces enhancements to the registry management system, emphasizing asynchronous loading and the incorporation of new features. The following changes have been implemented:
RegistryLoader Class:
A new class has been introduced to manage registry settings with asynchronous loading capabilities.
UpdateandCredentialpage settings:Updated code to use new loading routines.
Notification,Startup and Exit,SQL ServerandAppearancepages settings:Added registry settings.
Securitypage settings:Added registry settings and an encryption key generator for securely storing passwords in the registry.
Key Generator
Generates encrypted passwords and copies them to the clipboard for 30 seconds.
Code Cleanup:
Removed the obsolete
SaveConnectionsOnExitoption and commented some settings that may no longer be needed, marking them for future deletion.Documentation Update:
Updated documentation to reflect the new features and changes in registry settings.
Motivation and Context
I am motivated to contribute to the advancement of mRem by enhancing its functionality and performance. My goal is to support the development team in delivering a more efficient and user-friendly experience.
How Has This Been Tested?
Tested for/on:
Screenshots (if appropriate):
Secure Key Gen:
Types of changes
Checklist: