Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Favorites fails to reload when configured with SQL server 1.77 #1470

Copy link
Copy link

Description

@ng3727
Issue body actions

Expected Behavior

Favorites are reloaded when mRemoteNG is reloaded when using SQL/MySQL connections

Current Behavior

This feature is missing the local property reload

Possible Solution

mRemoteNG-develop\mRemoteV1\Config\Serializers\ConnectionSerializers\MsSql\LocalConnectionPropertiesXmlSerializer.cs

public IEnumerable<LocalConnectionPropertiesModel> Deserialize(string serializedData)
                  .Select(m => new XElement("Node",
                                          new XAttribute("ConnectionId", m.ConnectionId),
                                          new XAttribute("Connected", m.Connected),
                                          new XAttribute("Expanded", m.Expanded),
                                          new XAttribute("Favorite", m.Favorite) // added #1470
                                          ));
public IEnumerable<LocalConnectionPropertiesModel> Deserialize(string serializedData)
                     .Select(e => new LocalConnectionPropertiesModel
                   {
                       ConnectionId = e.Attribute("ConnectionId")?.Value,
                       Connected = bool.Parse(e.Attribute("Connected")?.Value ?? "False"),
                       Expanded = bool.Parse(e.Attribute("Expanded")?.Value ?? "False"),
                       Favorite = bool.Parse(e.Attribute("Favorite")?.Value ?? "False") // added #1470
                   });

Steps to Reproduce (for bugs)

  1. Load mRemoteNG, configure SQL Server settings
  2. Reload mRemoteNG
  3. Select a connection
  4. Set Favorite to Yes
  5. Unload mRemoteNG
  6. Load mRemoteNG
  7. No Favorite's are reloaded from the Local Settings

Context

The feature saves and reloads using the standard XML connection but not with SQL Server configured (haven't looked at the MySQL version)

Your Environment

  • Version used: mRemoteNG Version: 1.77.0 dev @31/05/2019
  • Operating System and version (e.g. Windows 10 1709 x64): Windows 10 Home 1809 17763.529
Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.