Fix handling of features above 32 bits or with offset#31
Merged
lromor merged 1 commit intoJun 25, 2025
lromor:mainlromor/fpga-assembler:mainfrom
gatecat:fix-feature-vectorsgatecat/fpga-assembler:fix-feature-vectorsCopy head branch name to clipboard
Merged
Fix handling of features above 32 bits or with offset#31lromor merged 1 commit intolromor:mainlromor/fpga-assembler:mainfrom gatecat:fix-feature-vectorsgatecat/fpga-assembler:fix-feature-vectorsCopy head branch name to clipboard
lromor merged 1 commit into
lromor:mainlromor/fpga-assembler:mainfrom
gatecat:fix-feature-vectorsgatecat/fpga-assembler:fix-feature-vectorsCopy head branch name to clipboard
Conversation
Signed-off-by: gatecat <gatecat@ds0.me>
Owner
|
Nice catch! Thanks for taking the time to debug this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two bugs spotted here:
(1 << feature_addr)was only a 32 bit value because neither1norfeature_addrwere 64 bits, so 64 bit features would be generated wronglybitsis not shifted bystart_bit, so the test of it should start from 0 rather thanstart_bitWith this I can get the himbaechel-xilinx blinky example to correctly build for arty-a35t using this for assembly.