Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update setup.py configuration#209

Open
huaibovip wants to merge 1 commit into
llnl:mainllnl/LEAP:mainfrom
huaibovip:mainhuaibovip/LEAP:mainCopy head branch name to clipboard
Open

Update setup.py configuration#209
huaibovip wants to merge 1 commit into
llnl:mainllnl/LEAP:mainfrom
huaibovip:mainhuaibovip/LEAP:mainCopy head branch name to clipboard

Conversation

@huaibovip

Copy link
Copy Markdown

This pull request updates the setup.py script to improve the build process and packaging of the native library for the leapct PyTorch module. The changes streamline how the compiled library is handled across platforms and ensure it is correctly included in the package distribution.

Build process and packaging improvements:

  • Unified the handling of build failures by moving the error check and exit logic after the platform-specific build commands, ensuring consistent behavior regardless of platform.
  • Replaced platform-specific logic for copying the compiled library with a single shutil.copy call that places the built library into the src/leapct directory, simplifying the code and ensuring the library is always in the expected package location.
  • Updated package_data to include the compiled library specifically within the leapct package and enabled include_package_data to ensure the library is distributed with the package.
  • Removed the py_modules entry for modules that are now included via find_packages, preventing redundancy and potential packaging issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.