Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Changes from libappimage#2

Closed
azubieta wants to merge 2 commits into
masterlinuxdeploy/linuxdeploy-desktopfile:masterfrom
changes_from_libappimagelinuxdeploy/linuxdeploy-desktopfile:changes_from_libappimageCopy head branch name to clipboard
Closed

Changes from libappimage#2
azubieta wants to merge 2 commits into
masterlinuxdeploy/linuxdeploy-desktopfile:masterfrom
changes_from_libappimagelinuxdeploy/linuxdeploy-desktopfile:changes_from_libappimageCopy head branch name to clipboard

Conversation

@azubieta

Copy link
Copy Markdown

Set of changes required in the new libappimage implementation

@azubieta azubieta force-pushed the changes_from_libappimage branch from 7a0febd to d1b74ed Compare December 29, 2018 00:28
@probonopd

Copy link
Copy Markdown

@azubieta does this mean that consumers of libappimage need to be changed in order to be able to use the c++ based version? In this case, let's make very sure that appimaged is also changed appropriately once the c++ based libappimage is available for general consumption.

@azubieta

Copy link
Copy Markdown
Author

@probonopd As far as I know, this lib is only used at linuxdeploy and at libappimage. appimaged uses the desktop integration functions from libappimage so it will receive the changes once migrated to the new implementation.

@TheAssassin

Copy link
Copy Markdown
Member

I don't see what this is PR is supposed to add to this library. "Needed by libappimage" is a bad description. Also, it doesn't follow the same strategies re. PImpl as the rest of the code does. Please improve the description to show what this is supposed to add, and fix the use of PImpl.

@azubieta

Copy link
Copy Markdown
Author

Closing it as no longer required.

@azubieta azubieta closed this Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.