feat: Add configuration logging for benchmark reproducibility + bug fixes#1898
Draft
saud5150 wants to merge 1 commit into
Draft
feat: Add configuration logging for benchmark reproducibility + bug fixes#1898saud5150 wants to merge 1 commit into
saud5150 wants to merge 1 commit into
Conversation
Contributor
|
/review |
Adds comprehensive configuration logging to ImageNet ResNet50 benchmarks: - Automatically saves full resolved config to config.txt in log directory - Captures all CLI arguments + derived values (global_batch_size, world_size, etc.) - Includes environment info (PyTorch version, CUDA availability, timestamp) - Optional --verbose flag to print config to console before training - Uses only Python stdlib (no new dependencies) Also fixes persistent_workers bug: - Fix ValueError when num_workers=0 with persistent_workers=True - Only enable persistent_workers when num_workers > 0
5c9649b to
daf9fb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive configuration logging to ImageNet ResNet50 benchmarks:
Also fixes persistent_workers bug: