customicons by uuid#417
Open
shining-fnml wants to merge 2 commits into
Open
customicons by uuid#417shining-fnml wants to merge 2 commits into
shining-fnml wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request slightly changes the behavior of
iconproperty getter in BaseElement and Entry. If the icon is a custom one then its uuid is returned instead of the index (nothing changes for the embedded icons).The new property (getter)
customIconsin class PyKeePass returns a dictionary ofuuid(str):png(bytes)containing all the attached custom icons in the database.For the moment these are read-only operations.