make collection lookups not slow#284
Closed
cantmediaus-design wants to merge 1 commit into
lambda-client:1.21.11lambda-client/lambda:1.21.11from
cantmediaus-design:perf/collection-hashset-lookupcantmediaus-design/lambda:perf/collection-hashset-lookupCopy head branch name to clipboard
Closed
make collection lookups not slow#284cantmediaus-design wants to merge 1 commit intolambda-client:1.21.11lambda-client/lambda:1.21.11from cantmediaus-design:perf/collection-hashset-lookupcantmediaus-design/lambda:perf/collection-hashset-lookupCopy head branch name to clipboard
cantmediaus-design wants to merge 1 commit into
lambda-client:1.21.11lambda-client/lambda:1.21.11from
cantmediaus-design:perf/collection-hashset-lookupcantmediaus-design/lambda:perf/collection-hashset-lookupCopy head branch name to clipboard
Conversation
CollectionSetting backing store changed from MutableList to LinkedHashSet so contains() is O(1) instead of O(N). Replaced stream().anyMatch() with pre-built HashSet in fillBlockEntityRenderStates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
so the CollectionSetting was using a MutableList this whole time which means every
contains()call was just going through the entire list one by one. switched it to LinkedHashSet so it actually does the lookup properlyalso that stream().anyMatch() in fillBlockEntityRenderStates was kinda rough, it was scanning through every block entity for each outline target every frame. just threw em in a HashSet first now
why
xray was doing like millions of comparisons per chunk rebuild because isSelected() gets called for basically every block and it was linear scanning a list of ~39 entries each time. thats not great
test
ran the client, loaded a world, toggled stuff on and off, nothing exploded