Feat: Added prefix command.#199
Merged
Merged
Feat: Added prefix command.#199
Conversation
emyfops
requested changes
Dec 20, 2025
| } | ||
| val prefixChar = prefix.first() | ||
| val configurable = Configuration.configurableByName("command")?: return@executeWithResult failure("No command configurable found.") | ||
| val setting = (configurable.settings.find { it.name == "prefix" }?: return@executeWithResult failure("No prefix setting found.")) as Setting<*, Char> |
Collaborator
There was a problem hiding this comment.
You can safe cast using as? instead of wrapping the setting with parenthesis and returning if it is null. Instead you safe cast and returns if the cast is also null
Contributor
Author
There was a problem hiding this comment.
it is correct now right?
emyfops
approved these changes
Dec 21, 2025
Collaborator
|
@KMatias123 change the |
emyfops
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefix command,
;prefix <something>People expect it and every other client has it :3