feat: add support for user supplied access token#174
Merged
tmac1973 merged 1 commit intoJun 11, 2024
mainlacework/python-sdk:mainfrom
tmacdonald/add-token-supportlacework/python-sdk:tmacdonald/add-token-supportCopy head branch name to clipboard
Merged
feat: add support for user supplied access token#174tmac1973 merged 1 commit intomainlacework/python-sdk:mainfrom tmacdonald/add-token-supportlacework/python-sdk:tmacdonald/add-token-supportCopy head branch name to clipboard
tmac1973 merged 1 commit into
mainlacework/python-sdk:mainfrom
tmacdonald/add-token-supportlacework/python-sdk:tmacdonald/add-token-supportCopy head branch name to clipboard
Conversation
Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
PengyuanZhao
approved these changes
Jun 11, 2024
marktabry
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Allow users to supply an access token to the SDK instead of an API key/secret. This brings the Python SDK up to parity with the go SDK regarding user supplied tokens. Additionally this feature is required by the Tech Alliances team for AWS marketplace integrations.
Testing:
Tested locally