Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test: retry failing tests and enable slack notification#164

Merged
tmac1973 merged 1 commit into
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2768/fix-failing-testslacework/python-sdk:tmacdonald/GROW-2768/fix-failing-testsCopy head branch name to clipboard
Feb 21, 2024
Merged

test: retry failing tests and enable slack notification#164
tmac1973 merged 1 commit into
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2768/fix-failing-testslacework/python-sdk:tmacdonald/GROW-2768/fix-failing-testsCopy head branch name to clipboard

Conversation

@tmac1973
Copy link
Copy Markdown
Contributor

Some tests fail because:

  • Objects are randomly selected and not all object types are suitable for all tests ( e.g. you can't close some alerts )
  • Object deletion is asynchronous resulting in the API returning a "GET" with containing an object thats already been deleted. This causes issues when attempting to get details on a deleted object

Solution:

Automatically retry some tests if they fail.

Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
@tmac1973 tmac1973 requested a review from a team as a code owner February 21, 2024 20:47
@tmac1973 tmac1973 merged commit a70775e into main Feb 21, 2024
@tmac1973 tmac1973 deleted the tmacdonald/GROW-2768/fix-failing-tests branch February 21, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.